Snowflake: preserve reluctant MATCH_RECOGNIZE quantifiers - #2510
Open
osipovartem wants to merge 2 commits into
Open
osipovartem wants to merge 2 commits into
osipovartem wants to merge 2 commits into
Conversation
osipovartem
force-pushed
the
snowflake-match-recognize-reluctant
branch
from
September 22, 2026 22:30
9274b3a to
80090eb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
+ Coverage 80.96% 80.98% +0.01%
==========================================
Files 42 42
Lines 33359 33365 +6
Branches 33359 33365 +6
==========================================
+ Hits 27009 27020 +11
Misses 2790 2790
+ Partials 3560 3555 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preserves the reluctant modifier on Snowflake/SQL
MATCH_RECOGNIZEquantifiers. Previously,A*?was represented as(A*)?, changing a reluctant zero-or-more quantifier into a nested optional repetition.The AST now represents this as
Repetition(A, Reluctant(ZeroOrMore)). ExistingRepetition(pattern, quantifier)construction remains unchanged, while the addedReluctantquantifier wrapper also covers+?,??, and range forms such as{2,4}?. Stacked quantifiers that are not the single reluctant suffix are rejected.Reference
Snowflake documents the reluctant suffix, its non-greedy semantics, and the supported quantifier forms in the
MATCH_RECOGNIZEpattern syntax.Tests
cargo +1.95.0 test --offline --all-features match_recognize(2 passed)cargo +1.95.0 test --offline --all-featurescargo +1.95.0 fmt --all -- --check